[ 
https://issues.apache.org/jira/browse/HDDS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675615#comment-16675615
 ] 

Nanda kumar commented on HDDS-737:
----------------------------------

[~linyiqun], thanks for the review.

bq.  I prefer to add additional try-catch for thread.sleep and get 
InterruptedException.
Good idea. Will address it in the next patch.

bq. Can we have a new unit test for the incremental container report?
I have added {{TestCloseContainerCommandHandler}} in HDDS-801 which tests 
whether ICR is properly triggered.
HDDS-801 also introduces {{OzoneContainer#updateContainerState}} call which 
triggers ICR, there is a bit of restructuring of code in the way we trigger ICR 
in HDDS-801.

> Introduce Incremental Container Report
> --------------------------------------
>
>                 Key: HDDS-737
>                 URL: https://issues.apache.org/jira/browse/HDDS-737
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>          Components: Ozone Datanode, SCM
>            Reporter: Nanda kumar
>            Assignee: Nanda kumar
>            Priority: Major
>         Attachments: HDDS-737.000.patch
>
>
> We will use Incremental Container Report (ICR) to immediately inform SCM when 
> there is some state change to the container in datanode. This will make sure 
> that SCM is updated as soon as the state of a container changes and doesn’t 
> have to wait for full container report.
> *When do we send ICR?*
> * When a container replica state changes from open/closing to closed
> * When a container replica state changes from open/closing to quasi closed
> * When a container replica state changes from quasi closed to closed
> * When a container replica is deleted in datanode
> * When a container replica is copied from another datanode
> * When a container replica is discovered to be corrupted



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to