[ https://issues.apache.org/jira/browse/HDFS-13984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676077#comment-16676077 ]
Jiandan Yang commented on HDFS-13984: -------------------------------------- Hi, [~jzhuge] The failed unit is not caused by this patch, and [~anatoli.shein] is resolving in HDFS-14047. I am confused about compiler warning, hdfs.c:3484 and libhdfs_wrapper.c:21 is not introduced by this patch. > getFileInfo of libhdfs call NameNode#getFileStatus twice > -------------------------------------------------------- > > Key: HDFS-13984 > URL: https://issues.apache.org/jira/browse/HDFS-13984 > Project: Hadoop HDFS > Issue Type: Improvement > Components: libhdfs > Reporter: Jiandan Yang > Assignee: Jiandan Yang > Priority: Major > Attachments: HDFS-13984.001.patch, HDFS-13984.002.patch > > > getFileInfo in hdfs.c calls *FileSystem#exists* first, then calls > *FileSystem#getFileStatus*. > *FileSystem#exists* also call *FileSystem#getFileStatus*, just as follows: > {code:java} > public boolean exists(Path f) throws IOException { > try { > return getFileStatus(f) != null; > } catch (FileNotFoundException e) { > return false; > } > } > {code} > and finally this leads to call NameNodeRpcServer#getFileInfo twice. > Actually we can implement by calling once. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org