[
https://issues.apache.org/jira/browse/HDFS-14035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677380#comment-16677380
]
Erik Krogen edited comment on HDFS-14035 at 11/6/18 10:50 PM:
--------------------------------------------------------------
This approach LGTM, thanks [~vagarychen]! A few comments:
* -Within NNProxyInfo, we changed serviceProxy from a HAServiceProtocol to a
{{ClientProtocol}}, should we also change the field name?- I think [~shv]'s
point #1 is actually more valid and supersedes this
* Should {{ClientProtocol#getHAServiceState()}} be annotated
{{@ReadOnly(isCoordinated = false)}} ?
* You changed {{HAServiceProtocol.HAServiceState}} to include a {{static}}
modifier, but it is redundant as {{HAServiceProtocol}} is an interface so all
inner classes are static (also all inner enums are static regardless of whether
their container is an interface).
was (Author: xkrogen):
This approach LGTM, thanks [~vagarychen]! A few comments:
* Within {{NNProxyInfo}}, we changed {{serviceProxy}} from a
{{HAServiceProtocol}} to a {{ClientProtocol}}, should we also change the field
name?
* Should {{ClientProtocol#getHAServiceState()}} be annotated
{{@ReadOnly(isCoordinated = false)}} ?
* You changed {{HAServiceProtocol.HAServiceState}} to include a {{static}}
modifier, but it is redundant as {{HAServiceProtocol}} is an interface so all
inner classes are static (also all inner enums are static regardless of whether
their container is an interface).
> NN status discovery does not leverage delegation token
> ------------------------------------------------------
>
> Key: HDFS-14035
> URL: https://issues.apache.org/jira/browse/HDFS-14035
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Chen Liang
> Assignee: Chen Liang
> Priority: Major
> Attachments: HDFS-14035-HDFS-12943.001.patch,
> HDFS-14035-HDFS-12943.002.patch, HDFS-14035-HDFS-12943.003.patch,
> HDFS-14035-HDFS-12943.004.patch, HDFS-14035-HDFS-12943.005.patch,
> HDFS-14035-HDFS-12943.006.patch, HDFS-14035-HDFS-12943.007.patch
>
>
> Currently ObserverReadProxyProvider uses
> {{HAServiceProtocol#getServiceStatus}} to get the status of each NN. However
> {{HAServiceProtocol}} does not leverage delegation token. So when running an
> application on YARN and when YARN node manager makes this call
> getServiceStatus, token authentication will fail, causing the application to
> fail.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
