[
https://issues.apache.org/jira/browse/HDFS-13985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677893#comment-16677893
]
Zsolt Venczel edited comment on HDFS-13985 at 11/7/18 9:23 AM:
---------------------------------------------------------------
Thanks for the patch [~adam.antal]!
I think the message content in line 43. is fine and is more meaningful.
Extending the message for the *public ReplicaNotFoundException(ExtendedBlock
b)* constructor with it makes sense.
I have some concerns with extending the message for the *public
ReplicaNotFoundException(String msg)* constructor as it has various use-cases
having various messages that can be distorted by this message extension (a few
examples in FsDatasetImpl). What do you think?
was (Author: zvenczel):
Thanks for the patch [~adam.antal]!
I think the message content in line 43. is fine and should be more meaningful.
Extending the message for the *public ReplicaNotFoundException(ExtendedBlock
b)* constructor with it makes sense.
I have some concerns with extending the message for the *public
ReplicaNotFoundException(String msg)* constructor as it has various use-cases
having various messages that can be distorted by this message extension (a few
examples in FsDatasetImpl). What do you think?
> Clearer error message for ReplicaNotFoundException
> --------------------------------------------------
>
> Key: HDFS-13985
> URL: https://issues.apache.org/jira/browse/HDFS-13985
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs
> Reporter: Adam Antal
> Assignee: Adam Antal
> Priority: Major
> Attachments: HDFS-13985.001.patch
>
>
> The issue is that we came across a ReplicaNotFoundException in a bug report,
> the most informative thing we could get is "Replica not found for
> [ExtendedBlock]". If someone tries to investigate cases including
> ReplicaNotFoundExceptions should review diagnostic bundles, dig through logs,
> but as a starting point enhancing the exception message would boost this
> process, and be beneficial in the long run.
> More concretely, it would be helpful if any of the following information was
> displayed along with the exception: file's name, replication factor or block
> location.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
