[ https://issues.apache.org/jira/browse/HDDS-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684573#comment-16684573 ]
Jitendra Nath Pandey commented on HDDS-675: ------------------------------------------- # The purpose of {{overWriteFlag}} in {{ChunkOutputStream}} is not clear to me. Are you using it for a retry upon an exception? Why wouldn't it work if we just rely on {{lastSuccessfulFlushIndex}}? # Default {{watch.request.timeout}} of 5 seconds is too aggressive, we should make it at least 30 seconds. # Change in {{XceiverClientManager}} seems unnecessary. If it is a cleanup, we should rather do it in a separate jira, because if Ratis is not relevant in this class, that should be removed as well. > Add blocking buffer and use watchApi for flush/close in OzoneClient > ------------------------------------------------------------------- > > Key: HDDS-675 > URL: https://issues.apache.org/jira/browse/HDDS-675 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: Ozone Client > Reporter: Shashikant Banerjee > Assignee: Shashikant Banerjee > Priority: Major > Attachments: HDDS-675.000.patch, HDDS-675.001.patch, > HDDS-675.002.patch, HDDS-675.003.patch, HDDS-675.004.patch, HDDS-675.005.patch > > > For handling 2 node failures, a blocking buffer will be used which will wait > for the flush commit index to get updated on all replicas of a container via > Ratis. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org