[
https://issues.apache.org/jira/browse/HDDS-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16686506#comment-16686506
]
Shashikant Banerjee commented on HDDS-801:
------------------------------------------
Thanks [~nandakumar131] for working on this. Some comments
1.KeyValueHandler.java : 865 -> update the comment to be container getting
"quasi closed" rather than getting closed.
2.KeyValueHandler.java : 865 -> closeContainer is exposed to clients in
ContainerProtocolCalls.Java. With SCMCLi as well, the close container can be
invoked where a client can directly close (closeContainer in
ContainerOperationClient). In such cases, a container in may be in just open
state and hence the exception will be thrown:
{code:java}
// The container has to be in CLOSING state.
if (state != State.CLOSING) {
ContainerProtos.Result error = state == State.INVALID ?
INVALID_CONTAINER_STATE : CONTAINER_INTERNAL_ERROR;
throw new StorageContainerException("Cannot close container #" +
container.getContainerData().getContainerID() + " while in " +
state + " state.", error);
}{code}
Should we disallow/remove the closeContainer call exposed to clients/SCMCLI?
3. Any state change in ContainerState should triggerICR.In that case,
closeContainer/quasiCloseContainer call should call updateContainerState
internally to send ICR instead of executing individually.
> Quasi close the container when close is not executed via Ratis
> --------------------------------------------------------------
>
> Key: HDDS-801
> URL: https://issues.apache.org/jira/browse/HDDS-801
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Ozone Datanode
> Affects Versions: 0.3.0
> Reporter: Nanda kumar
> Assignee: Nanda kumar
> Priority: Major
> Attachments: HDDS-801.000.patch, HDDS-801.001.patch,
> HDDS-801.002.patch
>
>
> When datanode received CloseContainerCommand and the replication type is not
> RATIS, we should QUASI close the container. After quasi-closing the container
> an ICR has to be sent to SCM.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
