[
https://issues.apache.org/jira/browse/HDFS-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095066#comment-13095066
]
Eli Collins commented on HDFS-2197:
-----------------------------------
Looks good. Minor comments:
* NameNodeRPCServer needs a license header
* The bodies of createSymlink, getLinkTarget, errorReport and addBlock look
like they belong in FSN (can punt to another change)
* MiniDFSCluster#isNameNodeUp should assert vs return false
> Refactor RPC call implementations out of NameNode class
> -------------------------------------------------------
>
> Key: HDFS-2197
> URL: https://issues.apache.org/jira/browse/HDFS-2197
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: hdfs-2197-2.txt, hdfs-2197.txt
>
>
> For HA, the NameNode will gain a bit of a state machine, to be able to
> transition between standby and active states. This would be cleaner in the
> code if the {{NameNode}} class were just a container for various services, as
> discussed in HDFS-1974. It's also nice for testing, where it would become
> easier to construct just the RPC handlers around a mock NameSystem, with no
> HTTP server, for example.
> This JIRA is to move all of the protocol implementations out of {{NameNode}}
> into a separate {{NameNodeRPCServer}} class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
