[
https://issues.apache.org/jira/browse/HDDS-658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16687864#comment-16687864
]
Elek, Marton commented on HDDS-658:
-----------------------------------
Thanks [~bharatviswa] the patch.
I tested it with full acceptance tests (passed) and with s3api
create-bucket/list-buckets (worked).
The code looks good to me, it moves the listing from the client side to the
server side which is exactly what we need .
During the review I found some minor problems.
The code calculates the s3 volume name based on specific user name and lists
all the ozone buckets inside them. It's possible that some evil user (=me)
creates ozone-only buckets in a s3 volume. In this case the list will be bad
(fix me If I am wrong) as it includes both the s3 and ozone-only buckets.
This is a very particular use case and this problem also exists in the the old
code. I will commit this patch as is, as it's definitely a good improvement. I
just start a discussion about this specific corner case and how can it be
handled in the future.
(ps: the checkstyle problems are fixed during the commit, the
TestOzoneManagerHttpServer unit test is passed locally)
> Implement s3 bucket list backend call and use it from rest endpoint
> -------------------------------------------------------------------
>
> Key: HDDS-658
> URL: https://issues.apache.org/jira/browse/HDDS-658
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: S3
> Reporter: Elek, Marton
> Assignee: Bharat Viswanadham
> Priority: Major
> Attachments: HDDS-658.00.patch
>
>
> HDDS-657 provides a very basic functionality for list buckets. There are two
> problems there:
> # It repeats the username -> volume name mapping convention.
> # Doesn't work if volume doesn't exist (no s3 buckets created, yet).
> The proper solution is to do the same on server side:
> # Use the existing naming convention in OM
> # Return empty list in case of value is missing.
> It requires an additional rpc call to the om.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
