[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688316#comment-16688316
]
Erik Krogen edited comment on HDFS-14017 at 11/15/18 4:37 PM:
--------------------------------------------------------------
Hey [~vagarychen], I think the new approach looks great! My comments are below.
* {{DFS_CLIENT_FAILOVER_IPFAILOVER_VIRTUAL_ADDRESS}} should probably live
within {{HdfsClientConfigKeys.Failover}}. Then it can also make use of
{{Failover.PREFIX}}.
* The change within {{ObserverReadProxyProvider}} is no longer necessary.
* The Javadoc on the ORPPWithIPFailover constructor doesn't make sense, it says
that IPFPP is the default for ORPP
* {{ORPPWithIPFailover#getProxyAddresses}} is looking the same as
{{AbstractNNFailoverProxyProvider#getProxyAddresses}}, is there any reason that
we need to override this? It seems that besides the new {{virtual-address}}
config, the rest of the configuration between ORPP and ORPPWithIPFailover is
the same, we should be able to just re-use this logic?
was (Author: xkrogen):
Hey [~vagarychen], I think the new approach looks great! My comments are below.
* {{DFS_CLIENT_FAILOVER_IPFAILOVER_VIRTUAL_ADDRESS}} should probably live
within {{HdfsClientConfigKeys.Failover}}. Then it can also make use of
{{Failover.PREFIX}}.
* The change within {{ObserverReadProxyProvider}} is no longer necessary.
* The Javadoc on the ORPPWithIPFailover constructor doesn't make sense, it says
that IPFPP is the default for ORPP
* {{ORPPWithIPFailover#getProxyAddresses}} is looking the same as
{{AbstractNNFailoverProxyProvider}}, is there any reason that we need to
override this? It seems that besides the new {{virtual-address}} config, the
rest of the configuration between ORPP and ORPPWithIPFailover is the same, we
should be able to just re-use this logic?
> ObserverReadProxyProviderWithIPFailover should work with HA configuration
> -------------------------------------------------------------------------
>
> Key: HDFS-14017
> URL: https://issues.apache.org/jira/browse/HDFS-14017
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Chen Liang
> Assignee: Chen Liang
> Priority: Major
> Attachments: HDFS-14017-HDFS-12943.001.patch,
> HDFS-14017-HDFS-12943.002.patch, HDFS-14017-HDFS-12943.003.patch,
> HDFS-14017-HDFS-12943.004.patch, HDFS-14017-HDFS-12943.005.patch,
> HDFS-14017-HDFS-12943.006.patch, HDFS-14017-HDFS-12943.008.patch,
> HDFS-14017-HDFS-12943.009.patch, HDFS-14017-HDFS-12943.010.patch,
> HDFS-14017-HDFS-12943.011.patch, HDFS-14017-HDFS-12943.012.patch
>
>
> Currently {{ObserverReadProxyProviderWithIPFailover}} extends
> {{ObserverReadProxyProvider}}, and the only difference is changing the proxy
> factory to use {{IPFailoverProxyProvider}}. However this is not enough
> because when calling constructor of {{ObserverReadProxyProvider}} in
> super(...), the follow line:
> {code:java}
> nameNodeProxies = getProxyAddresses(uri,
> HdfsClientConfigKeys.DFS_NAMENODE_RPC_ADDRESS_KEY);
> {code}
> will try to resolve the all configured NN addresses to do configured
> failover. But in the case of IPFailover, this does not really apply.
>
> A second issue closely related is about delegation token. For example, in
> current IPFailover setup, say we have a virtual host nn.xyz.com, which points
> to either of two physical nodes nn1.xyz.com or nn2.xyz.com. In current HDFS,
> there is always only one DT being exchanged, which has hostname nn.xyz.com.
> Server only issues this DT, and client only knows the host nn.xyz.com, so all
> is good. But in Observer read, even with IPFailover, the client will no
> longer contacting nn.xyz.com, but will actively reaching to nn1.xyz.com and
> nn2.xyz.com. During this process, current code will look for DT associated
> with hostname nn1.xyz.com or nn2.xyz.com, which is different from the DT
> given by NN. causing Token authentication to fail. This happens in
> {{AbstractDelegationTokenSelector#selectToken}}. New IPFailover proxy
> provider will need to resolve this as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
