[
https://issues.apache.org/jira/browse/HDDS-825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688876#comment-16688876
]
Arpit Agarwal commented on HDDS-825:
------------------------------------
+1 for the rebased patch. Thanks [~anu].
> Code cleanup based on messages from ErrorProne
> ----------------------------------------------
>
> Key: HDDS-825
> URL: https://issues.apache.org/jira/browse/HDDS-825
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Affects Versions: 0.3.0
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Priority: Major
> Attachments: HDDS-825.001.patch, HDDS-825.002.patch,
> HDDS-825.003.patch, HDDS-825.004.patch, HDDS-825.005.patch
>
>
> I ran ErrorProne (http://errorprone.info/) on Ozone/HDDS code base and it
> threw lots of errors. This patch fixes many issues pointed out by ErrorProne.
> The main classes of errors fixed in this patch are:
> * http://errorprone.info/bugpattern/DefaultCharset
> * http://errorprone.info/bugpattern/ComparableType
> * http://errorprone.info/bugpattern/StringSplitter
> * http://errorprone.info/bugpattern/IntLongMath
> * http://errorprone.info/bugpattern/JavaLangClash
> * http://errorprone.info/bugpattern/CatchFail
> * http://errorprone.info/bugpattern/JdkObsolete
> * http://errorprone.info/bugpattern/AssertEqualsArgumentOrderChecker
> * http://errorprone.info/bugpattern/CatchAndPrintStackTrace
> It is pretty educative to read through these errors and see the mistakes we
> made.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
