[
https://issues.apache.org/jira/browse/HDDS-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689022#comment-16689022
]
Dinesh Chitlangia edited comment on HDDS-120 at 11/16/18 4:34 AM:
------------------------------------------------------------------
[~xyao]
{quote} if we conditionally create the auditmsg object as needed like below, we
should be able to avoid the object creation if not needed.
{quote}
I am +1 on this approach. Similarly when logging the failure, we can also do a
check as follows as by default success events are audited as Info and failure
as Error in our Ozone Audit design.
{code:java}
if (AUDIT.getLogger().isErrorEnabled()){code}
Let me know if this sounds good then I can post the updated patch.
was (Author: dineshchitlangia):
[~xyao]
{quote} if we conditionally create the auditmsg object as needed like below, we
should be able to avoid the object creation if not needed.
{quote}
I am +1 on this approach. Similarly when logging the failure, we can also do a
check as follows as by default success events are audited as Info and failure
as Error in our Ozone Audit design.
if (AUDIT.getLogger().isErrorEnabled())
Let me know if this sounds good then I can post the updated patch.
> Adding HDDS datanode Audit Log
> ------------------------------
>
> Key: HDDS-120
> URL: https://issues.apache.org/jira/browse/HDDS-120
> Project: Hadoop Distributed Data Store
> Issue Type: New Feature
> Reporter: Xiaoyu Yao
> Assignee: Dinesh Chitlangia
> Priority: Major
> Labels: alpha2, logging
> Attachments: HDDS-120.001.patch, HDDS-120.002.patch,
> HDDS-120.003.patch, HDDS-120.004.patch, HDDS-120.005.patch, HDDS-120.006.patch
>
>
> This can be useful to find users who overload the DNs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
