[ https://issues.apache.org/jira/browse/HDDS-844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689423#comment-16689423 ]
Mukul Kumar Singh commented on HDDS-844: ---------------------------------------- Thanks for working on this [~ljain]. The patch looks really good to me. Some minor comments. 1) Lets add the teardown handling as part of StaleNodeHandler. 2) Also there are 3 endpoints triggering PipelineDestroy, can pipeline destroy to nodes be encapsulated inside a function. > Add logic for pipeline teardown after timeout > --------------------------------------------- > > Key: HDDS-844 > URL: https://issues.apache.org/jira/browse/HDDS-844 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: SCM > Affects Versions: 0.4.0 > Reporter: Lokesh Jain > Assignee: Lokesh Jain > Priority: Major > Attachments: HDDS-844.001.patch, HDDS-844.002.patch > > > On receiving pipeline action we close the pipeline and wait for all > containers to get closed. Currently pipeline is destroyed on datanodes only > after all the containers have been closed. There is a possibility for > containers to never get to CLOSED state if there is a two node failure. In > such scenarios the pipeline needs to be destroyed and removed from SCM after > a timeout. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org