[
https://issues.apache.org/jira/browse/HDFS-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690164#comment-16690164
]
Daniel Templeton commented on HDFS-14015:
-----------------------------------------
{quote}assuming this is tested (e.g. hard code the DetachCurrentThread return
to be non zero and eye-checked stderr){quote}
I have tested this method manually. The results look like:
{noformat}detachCurrentThreadFromJvm: Unable to detach thread
Thread[MyThread,10,MyGroup]:10 from the JVM. Error code: -1{noformat}
Having addressed [~xiaochen]'s concerns, I'm going to invoke his +1 and commit.
Thanks, [~xiaochen], [~pranay_singh], [~yzhangal], and [~jojochuang] for the
reviews.
> Improve error handling in hdfsThreadDestructor in native thread local storage
> -----------------------------------------------------------------------------
>
> Key: HDFS-14015
> URL: https://issues.apache.org/jira/browse/HDFS-14015
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: native
> Affects Versions: 3.0.0
> Reporter: Daniel Templeton
> Assignee: Daniel Templeton
> Priority: Major
> Attachments: HDFS-14015.001.patch, HDFS-14015.002.patch,
> HDFS-14015.003.patch, HDFS-14015.004.patch, HDFS-14015.005.patch,
> HDFS-14015.006.patch, HDFS-14015.007.patch, HDFS-14015.008.patch,
> HDFS-14015.009.patch, HDFS-14015.010.patch, HDFS-14015.011.patch,
> HDFS-14015.012.patch
>
>
> In the hdfsThreadDestructor() function, we ignore the return value from the
> DetachCurrentThread() call. We are seeing cases where a native thread dies
> while holding a JVM monitor, and it doesn't release the monitor. We're
> hoping that logging this error instead of ignoring it will shed some light on
> the issue. In any case, it's good programming practice.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
