[ 
https://issues.apache.org/jira/browse/HDFS-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096013#comment-13096013
 ] 

Uma Maheswara Rao G commented on HDFS-2299:
-------------------------------------------

Hey Aaron, Yes, I ran the test-patch.It did not show any warnings.
It looks to me that we need not even add exclude tag in RAT configuration 
item.Because HDFS already has that excluded. Because of that it did not show 
any warnings if i add/don't add in common.adding exclude tag is no use in 
common.

In HDFS pom.xml:

{code}
 <exclude>src/test/resources/data*</exclude>
 <exclude>src/test/resources/editStored*</exclude>
 <exclude>src/test/resources/empty-file</exclude>
{code}

I just removed the Apache header from editStored.xml.

Test-Patch results:

 +1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 6 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

+1 release audit. The applied patch does not increase the total number of 
release audit warnings.


Thanks 
Uma

> TestOfflineEditsViewer is failing on trunk
> ------------------------------------------
>
>                 Key: HDFS-2299
>                 URL: https://issues.apache.org/jira/browse/HDFS-2299
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.24.0
>            Reporter: Aaron T. Myers
>            Assignee: Uma Maheswara Rao G
>             Fix For: 0.24.0
>
>         Attachments: HDFS-2299.1.patch, HDFS-2299.2.patch, HDFS-2299.patch, 
> HDFS-2299.patch
>
>
> The relevant bit of the error:
> {noformat}
> -------------------------------------------------------------------------------
> Test set: 
> org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
> -------------------------------------------------------------------------------
> Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 5.652 sec <<< 
> FAILURE!
> testStored(org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer)
>   Time elapsed: 0.038 sec  <<< FAILURE!
> java.lang.AssertionError: Reference XML edits and parsed to XML should be same
> {noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to