[ 
https://issues.apache.org/jira/browse/HDDS-718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691324#comment-16691324
 ] 

Mukul Kumar Singh commented on HDDS-718:
----------------------------------------

Thanks for working on this [~ljain]. The patch looks really good to me. Some 
minor comments.

1) Pipeline.java:191, there are two toString methods, lets keep one of the 
methods.
2) PipelineStateMap.java:122, lets return a collections here and not construct 
a new ArrayList.


> Introduce new SCM Commands to list and close Pipelines
> ------------------------------------------------------
>
>                 Key: HDDS-718
>                 URL: https://issues.apache.org/jira/browse/HDDS-718
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>          Components: SCM
>            Reporter: Nanda kumar
>            Assignee: Lokesh Jain
>            Priority: Blocker
>         Attachments: HDDS-718.001.patch, HDDS-718.002.patch
>
>
> We need to have a tear-down pipeline command in SCM so that an administrator 
> can close/destroy a pipeline in the cluster.
> HDDS-695 brings in the commands in branch ozone-0.3, this Jira is for porting 
> them to trunk.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to