[
https://issues.apache.org/jira/browse/HDDS-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692206#comment-16692206
]
Ajay Kumar edited comment on HDDS-795 at 11/19/18 8:16 PM:
-----------------------------------------------------------
[~elek] thanks for updating the patch.
patch v5 still has a typo at L109 , {{DBStore}}. Either we can remove "a" or
rephrase whole line.
{quote}Can't use this name exactly, as I have both put and delete operations
with and without batch batch support. I need two new names.{quote}
I was thinking of taking a generic parameter to handle both put and delete but
current approach is good as well as we don't have too many operations.
was (Author: ajayydv):
[~elek] thanks for updating the patch.
patch v5 still has a typo at L109 , {{DBStore}}. Either we can remove "a" or
rephrase whole line.
{quote}Can't use this name exactly, as I have both put and delete operations
with and without batch batch support. I need two new names.{quote}
I was thinking of making taking a generic parameter to handle both put and
delete but current approach is good as well as we don't have too many
operations.
> RocksDb specific classes leak from DBStore/Table interfaces
> -----------------------------------------------------------
>
> Key: HDDS-795
> URL: https://issues.apache.org/jira/browse/HDDS-795
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Attachments: HDDS-795.001.patch, HDDS-795.002.patch,
> HDDS-795.003.patch, HDDS-795.004.patch, HDDS-795.005.patch
>
>
> org.apache.hadoop.utils.db.RocksDB and Table interfaces provide a
> vendor-independent way to access any key value store.
> The default implementation uses RocksDb but other implementation also could
> be used (for example an InMemory implementation for testing only).
> The current Table interface contains methods which depend on RocksDB specific
> classes. For example:
> {code}
> public interface DBStore extends AutoCloseable {
> //...
> /**
> * Return the Column Family handle. TODO: This leaks an RockDB abstraction
> * into Ozone code, cleanup later.
> *
> * @return ColumnFamilyHandle
> */
> ColumnFamilyHandle getHandle();
> //...
> {code}
> We need to remove the RocksDB specific classes from the generic interfaces.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
