[
https://issues.apache.org/jira/browse/HDDS-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16692411#comment-16692411
]
Ajay Kumar commented on HDDS-808:
---------------------------------
[~dineshchitlangia] My comment was about enum classes. We don't need those
String constructors. We can keep getAction and return corresponding string
value of enum variable. I am also fine with making AuditAction a marker
interface.
> Simplify OMAction and DNAction classes used for AuditLogging
> ------------------------------------------------------------
>
> Key: HDDS-808
> URL: https://issues.apache.org/jira/browse/HDDS-808
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Ozone Datanode, Ozone Manager
> Reporter: Dinesh Chitlangia
> Assignee: Dinesh Chitlangia
> Priority: Minor
> Labels: logging
>
> While reviewing HDDS-120, [~ajayydv] suggested to simplify these class by
> removing the constructor and the getAction().
> Refer review comment:
> https://issues.apache.org/jira/browse/HDDS-120?focusedCommentId=16670495&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16670495
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
