[
https://issues.apache.org/jira/browse/HDFS-14078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693441#comment-16693441
]
Arpit Agarwal commented on HDFS-14078:
--------------------------------------
The patch looks good. Thanks for fixing this [~elek].
Similar suggestion as [~ayushtkn]. Let's remove the line number and do a prefix
match on the string to make the test more robust.
> Admin helper fails to prettify NullPointerExceptions
> ----------------------------------------------------
>
> Key: HDFS-14078
> URL: https://issues.apache.org/jira/browse/HDFS-14078
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Attachments: HDFS-14078.001.patch, HDFS-14078.002.patch
>
>
> org.apache.hadoop.hdfs.tools.AdminHelper has a method to prettifyExceptions:
> {code}
> static String prettifyException(Exception e) {
> return e.getClass().getSimpleName() + ": "
> + e.getLocalizedMessage().split("\n")[0];
> }
> {code}
> But if e is a NPE the e.getLocalizedMessage() could be null. In that case NPE
> will be thrown and the original error message will be lost.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
