[ 
https://issues.apache.org/jira/browse/HDFS-14006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693845#comment-16693845
 ] 

Íñigo Goiri commented on HDFS-14006:
------------------------------------

The refactor looks pretty reasonable.
I have a couple nits:
* Line break before the javadoc in {{TokenVerifier}}.
* {{web hdfs}} to {{WebHDFS}}.
* A little longer javadoc in {{TokenVerifier}} to explain who uses this and so 
on.
* Move the javadoc to {{TokenVerifier#verifyToken}} and leave 
{{NameNode#verifyToken}} as Override without javadoc.

I would also change the title of the JIRA there is no RBF change here, all 
there is a refactor in the NN.

> RBF: Support to get Router object from web context instead of Namenode
> ----------------------------------------------------------------------
>
>                 Key: HDFS-14006
>                 URL: https://issues.apache.org/jira/browse/HDFS-14006
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: CR Hota
>            Assignee: CR Hota
>            Priority: Major
>         Attachments: HDFS-14006.001.patch
>
>
> Router currently uses Namenode web resources to read and verify delegation 
> tokens. This model doesn't work when router will be deployed in secured mode. 
> This change will introduce router's own UserProvider resource and 
> dependencies.
> In the current deployment one can see this exception.
> {"RemoteException":\{"exception":"ClassCastException","javaClassName":"java.lang.ClassCastException","message":"org.apache.hadoop.hdfs.server.federation.router.Router
>  cannot be cast to org.apache.hadoop.hdfs.server.namenode.NameNode"}}
> In the proposed change, router will maintain its own web resource, that will 
> be similar to current namenode, but modified to get back a router instance 
> instead of namenode.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to