[
https://issues.apache.org/jira/browse/HDDS-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693846#comment-16693846
]
Arpit Agarwal edited comment on HDDS-816 at 11/20/18 10:21 PM:
---------------------------------------------------------------
A few comments:
# You can just replace this comment:
{code:java}
* Returns number of rows in a table. This should not be used on the keyTable
* which will take a very long time. Currently this is used for counting now
* of buckets and volumes from bucket and volume table during OM start.
{code}
with something like
{code:java}
* Returns number of rows in a table. This should not be used for very large
tables.
{code}
# Should _intialized = true_ be set inside the start method itself? Else the
second time you invoke start, initialized will be left to false.
# Bad import in OMMetadataManager.java and OmMetadataManagerImpl. Where is it
being used?
{code:java}
import com.sun.tools.internal.ws.wsdl.document.jaxws.Exception;
{code}
# Let's avoid caching a copy of the conf object. It's better to pass
configuration as a parameter to the start routine. This applies to both
KeyManagerImpl and OmMetadataManagerImpl.
{code:java}
this.configuration = conf;
{code}
# Let's Remove this comment line.
{code:java}
// Which can be useful for ozone admins, to know about the system.
{code}
# I think this comment can be made clearer:
{code:java}
//TODO: After an unclean shutdown, this value might have inaccuracy of
// actual original key count. The inaccuracy can be invalid forever and
// the difference depends from the persisting time period + no of keys
// created during this period.
{code}
Instead you can say something like
{code:java}
This metric is an estimate and it may be inaccurate on restart if the OM
process was not shutdown cleanly.
Key creations/deletions in the last few minutes before restart may not be
included in this count.
{code}
was (Author: arpitagarwal):
A few comments:
# You can just replace this comment:
{code:java}
* Returns number of rows in a table. This should not be used on the keyTable
* which will take a very long time. Currently this is used for counting now
* of buckets and volumes from bucket and volume table during OM start.
{code}
with something like
{code:java}
* Returns number of rows in a table. This should not be used for very large
tables.
{code}
# Should _intialized = true_ be set inside the start method itself? Else the
second time you invoke start, initialized will be left to false.
# Bad import in OMMetadataManager.java and OmMetadataManagerImpl. Where is it
being used?
{code:java}
import com.sun.tools.internal.ws.wsdl.document.jaxws.Exception;
{code}
# Let's avoid caching a copy of the conf object. It's better to pass
configuration as a parameter to the start routine. This applies to both
KeyManagerImpl and OmMetadataManagerImpl.
{code:java}
this.configuration = conf;
{code}
# Let's Remove this comment line.
{code:java}
// Which can be useful for ozone admins, to know about the system.
{code}
# I think this comment can be made clearer:
{code:java}
//TODO: After an unclean shutdown, this value might have inaccuracy of
// actual original key count. The inaccuracy can be invalid forever and
// the difference depends from the persisting time period + no of keys
// created during this period.
{code}
Instead you can say something like
{code:java}
This metric is an estimate and it may be inaccurate on restart if the OM
process was not shutdown cleanly.
Key creations/deletions in the last few minutes before restart may not be
included in this count.
{code}
> Create OM metrics for bucket, volume, keys
> ------------------------------------------
>
> Key: HDDS-816
> URL: https://issues.apache.org/jira/browse/HDDS-816
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Manager
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Attachments: HDDS-816.00.patch, HDDS-816.01.patch, HDDS-816.03.patch,
> HDDS-816.04.patch, HDDS-816.05.patch, HDDS-816.06.patch, HDDS-816.07.patch,
> Metrics for number of volumes, buckets, keys.pdf, Proposed Approach.pdf
>
>
> This Jira is used to create the following metrics in Ozone manager.
> # number of volumes
> # number of buckets
> # number of keys
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
