[ 
https://issues.apache.org/jira/browse/HDFS-13893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698125#comment-16698125
 ] 

Ayush Saxena commented on HDFS-13893:
-------------------------------------

Thanx [~ljain] for working on this.The overall fix looks good.

Small query. In case of validateArguments() should we throw parse exception or 
HadoopIllelagArgumentException()?

>From HadoopIllelagArgumentException()
{code:java}
* Indicates that a method has been passed illegal or invalid argument.
{code}

Is this validateArguments() supposed to be called from any other place too? If 
not we can directly have a check in the same method. :)

> DiskBalancer: no validations for Disk balancer commands 
> --------------------------------------------------------
>
>                 Key: HDFS-13893
>                 URL: https://issues.apache.org/jira/browse/HDFS-13893
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: diskbalancer
>            Reporter: Harshakiran Reddy
>            Assignee: Lokesh Jain
>            Priority: Major
>              Labels: newbie
>         Attachments: HDFS-13893.001.patch
>
>
> {{Scenario:-}}
>  
>  1 Run the Disk Balancer commands with extra arguments passing  
> {noformat} 
> hadoopclient> hdfs diskbalancer -plan hostname --thresholdPercentage 2 
> *sgfsdgfs*
> 2018-08-31 14:57:35,454 INFO planner.GreedyPlanner: Starting plan for Node : 
> hostname:50077
> 2018-08-31 14:57:35,457 INFO planner.GreedyPlanner: Disk Volume set 
> fb67f00c-e333-4f38-a3a6-846a30d4205a Type : DISK plan completed.
> 2018-08-31 14:57:35,457 INFO planner.GreedyPlanner: Compute Plan for Node : 
> hostname:50077 took 23 ms
> 2018-08-31 14:57:35,457 INFO command.Command: Writing plan to:
> 2018-08-31 14:57:35,457 INFO command.Command: 
> /system/diskbalancer/2018-Aug-31-14-57-35/hostname.plan.json
> Writing plan to:
> /system/diskbalancer/2018-Aug-31-14-57-35/hostname.plan.json
> {noformat} 
> Expected Output:- 
> =============
> Disk balancer commands should be fail if we pass any invalid arguments or 
> extra arguments.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to