[
https://issues.apache.org/jira/browse/HDFS-14103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701031#comment-16701031
]
BELUGA BEHR commented on HDFS-14103:
------------------------------------
The unit test is:
{code}
java.lang.AssertionError: Wrong number of PendingReplication blocks
expected:<2> but was:<1>
{code}
I reviewed my work again and I only changed logging, so would not expect any
functional changes.
The {{builder}} object can never be 'null'. There are several other instances
in the code where {{builder}} is accessed without checking for a 'null' value
so I am simply unifying the code.
> Review Logging of BlockPlacementPolicyDefault
> ---------------------------------------------
>
> Key: HDFS-14103
> URL: https://issues.apache.org/jira/browse/HDFS-14103
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Minor
> Attachments: HDFS-14103.1.patch
>
>
> Review use of SLF4J in {{BlockPlacementPolicyDefault.java}}
> Other minor logging improvements.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]