[
https://issues.apache.org/jira/browse/HDDS-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704849#comment-16704849
]
Yiqun Lin edited comment on HDDS-886 at 11/30/18 2:56 PM:
----------------------------------------------------------
The UT failures is broken by HDDS-284 and tracked in HDDS-885 now.
Commit this shortly.
was (Author: linyiqun):
The UT failures is borken HDDS-284 and tracked in HDDS-885.
Commit this shortly.
> Unnecessary buffer copy in HddsDispatcher#dispatch
> --------------------------------------------------
>
> Key: HDDS-886
> URL: https://issues.apache.org/jira/browse/HDDS-886
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Datanode
> Reporter: Lokesh Jain
> Assignee: Lokesh Jain
> Priority: Major
> Fix For: 0.4.0
>
> Attachments: HDDS-886.001.patch
>
>
> In HddsDispatcher#dispatch precondition not null check converts container
> command to a string object. This is done even for a write chunk command which
> means we copy the chunk data to a string.
> {code:java}
> // code placeholderpublic ContainerCommandResponseProto dispatch(
> ContainerCommandRequestProto msg) {
> LOG.trace("Command {}, trace ID: {} ", msg.getCmdType().toString(),
> msg.getTraceID());
> Preconditions.checkNotNull(msg.toString());
> {code}
> The precondition needs to check only the msg.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
