[ 
https://issues.apache.org/jira/browse/HDFS-14103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705370#comment-16705370
 ] 

BELUGA BEHR edited comment on HDFS-14103 at 11/30/18 10:42 PM:
---------------------------------------------------------------

[~giovanni.fumarola] What do you mean?  All of the changes or just the null 
checks?

 

Please refer to SLF4J docs regarding these changes:

[https://www.slf4j.org/faq.html#logging_performance]

I also think it makes the code much more readable.


was (Author: belugabehr):
[~giovanni.fumarola] What do you mean?  All of the changes or just the null 
checks?

 

Please refer to SLF4J docs regarding these changes:

https://www.slf4j.org/faq.html#logging_performance

> Review Logging of BlockPlacementPolicyDefault
> ---------------------------------------------
>
>                 Key: HDFS-14103
>                 URL: https://issues.apache.org/jira/browse/HDFS-14103
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Minor
>         Attachments: HDFS-14103.1.patch, HDFS-14103.1.patch
>
>
> Review use of SLF4J in {{BlockPlacementPolicyDefault.java}}
> Other minor logging improvements.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to