[ 
https://issues.apache.org/jira/browse/HDFS-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097674#comment-13097674
 ] 

Hadoop QA commented on HDFS-2197:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12493092/hdfs-2197-trunk-final.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 101 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1201//console

This message is automatically generated.

> Refactor RPC call implementations out of NameNode class
> -------------------------------------------------------
>
>                 Key: HDFS-2197
>                 URL: https://issues.apache.org/jira/browse/HDFS-2197
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hdfs-2197-2.txt, hdfs-2197-3.txt, hdfs-2197-4.txt, 
> hdfs-2197-trunk-final.txt, hdfs-2197.txt
>
>
> For HA, the NameNode will gain a bit of a state machine, to be able to 
> transition between standby and active states. This would be cleaner in the 
> code if the {{NameNode}} class were just a container for various services, as 
> discussed in HDFS-1974. It's also nice for testing, where it would become 
> easier to construct just the RPC handlers around a mock NameSystem, with no 
> HTTP server, for example.
> This JIRA is to move all of the protocol implementations out of {{NameNode}} 
> into a separate {{NameNodeRPCServer}} class.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to