[ 
https://issues.apache.org/jira/browse/HDFS-13818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707647#comment-16707647
 ] 

Hudson commented on HDFS-13818:
-------------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15548 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/15548/])
HDFS-13818. Extend OIV to detect FSImage corruption. Contributed by Adam 
(weichiu: rev fb10803dfa67394650072bdea327296f8ad2a744)
* (add) 
hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testSingleFileCorruption.csv
* (edit) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java
* (edit) 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java
* (add) 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestPBImageCorruption.java
* (add) 
hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testMultipleFileCorruption.csv
* (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsImageViewer.md
* (add) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageCorruptionDetector.java
* (edit) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageDelimitedTextWriter.java
* (edit) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageTextWriter.java
* (add) 
hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testSingleFolderCorruption.csv
* (add) 
hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testMultipleCorruption.csv
* (add) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageCorruption.java


> Extend OIV to detect FSImage corruption
> ---------------------------------------
>
>                 Key: HDFS-13818
>                 URL: https://issues.apache.org/jira/browse/HDFS-13818
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs
>            Reporter: Adam Antal
>            Assignee: Adam Antal
>            Priority: Major
>             Fix For: 3.3.0
>
>         Attachments: HDFS-13818.001.patch, HDFS-13818.002.patch, 
> HDFS-13818.003.patch, HDFS-13818.003.patch, HDFS-13818.004.patch, 
> HDFS-13818.005.patch, HDFS-13818.006.patch, HDFS-13818.007.patch, 
> HDFS-13818.008.patch, HDFS-13818.009.patch, 
> OIV_CorruptionDetector_processor.001.pdf, 
> OIV_CorruptionDetector_processor.002.pdf
>
>
> A follow-up Jira for HDFS-13031: an improvement of the OIV is suggested for 
> detecting corruptions like HDFS-13101 in an offline way.
> The reasoning is the following. Apart from a NN startup throwing the error, 
> there is nothing in the customer's hand that could reassure him/her that the 
> FSImages is good or corrupted.
> Although real full checking of the FSImage is only possible by the NN, for 
> stack traces associated with the observed corruption cases the solution of 
> putting up a tertiary NN is a little bit of overkill. The OIV would be a 
> handy choice, already having functionality like loading the fsimage and 
> constructing the folder structure, we just have to add the option of 
> detecting the null INodes. For e.g. the Delimited OIV processor can already 
> use in disk MetadataMap, which reduces memory consumption. Also there may be 
> a window for parallelizing: iterating through INodes for e.g. could be done 
> distributed, increasing efficiency, and we wouldn't need a high mem-high CPU 
> setup for just checking the FSImage.
> The suggestion is to add a --detectCorruption option to the OIV which would 
> check the FSImage for consistency.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to