[
https://issues.apache.org/jira/browse/HDFS-14119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707806#comment-16707806
]
Hudson commented on HDFS-14119:
-------------------------------
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15551 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/15551/])
HDFS-14119. Improve GreedyPlanner Parameter Logging. Contributed by (gifuma:
rev 69489ff2d18a26be9c56d632672079e134f1cd99)
* (edit)
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/diskbalancer/planner/GreedyPlanner.java
> Improve GreedyPlanner Parameter Logging
> ---------------------------------------
>
> Key: HDFS-14119
> URL: https://issues.apache.org/jira/browse/HDFS-14119
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs
> Affects Versions: 3.3.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Trivial
> Fix For: 3.3.0
>
> Attachments: HDFS-14119.1.patch
>
>
> 1. Do not use {{String.format()}} in conjunction with SLF4J. Superfluous.
> {code:java}
> String message = String
> .format("Compute Plan for Node : %s:%d took %d ms ",
> node.getDataNodeName(), node.getDataNodePort(),
> endTime - startTime);
> LOG.info(message);{code}
> 2. Do not call an explicit toString() on an object with SLF4J parameter.
> Otherwise, the string will be created and then thrown away if the logger is
> not set to debug level. Just pass the object itself and the framework will
> call {{toString}} if needed.
> {code}
> LOG.debug("Step : {} ", nextStep.toString());
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
