[
https://issues.apache.org/jira/browse/HDFS-14114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16708624#comment-16708624
]
Hadoop QA commented on HDFS-14114:
----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color}
| {color:red} HDFS-14114 does not apply to HDFS-13891. Rebase required? Wrong
Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HDFS-14114 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12950549/HDFS-14114-HDFS-13891.001.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/25712/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> RBF: MIN_ACTIVE_RATIO should be configurable
> --------------------------------------------
>
> Key: HDFS-14114
> URL: https://issues.apache.org/jira/browse/HDFS-14114
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Fei Hui
> Assignee: Fei Hui
> Priority: Major
> Fix For: HDFS-13891
>
> Attachments: HDFS-14114-HDFS-13891.001.patch, HDFS-14114.001.patch,
> HDFS-14114.002.patch, HDFS-14114.003.patch, HDFS-14114.004.patch,
> HDFS-14114.005.patch, HDFS-14114.006.patch, HDFS-14114.007.patch,
> HDFS-14114.008.patch
>
>
> The following code contains
> {code:java}
> if (timeSinceLastActive > connectionCleanupPeriodMs ||
> active < MIN_ACTIVE_RATIO * total) {
> // Remove and close 1 connection
> List<ConnectionContext> conns = pool.removeConnections(1);
> for (ConnectionContext conn : conns) {
> conn.close();
> }
> LOG.debug("Removed connection {} used {} seconds ago. " +
> "Pool has {}/{} connections", pool.getConnectionPoolId(),
> TimeUnit.MILLISECONDS.toSeconds(timeSinceLastActive),
> pool.getNumConnections(), pool.getMaxSize());
> }
> ...
> if (pool.getNumConnections() < pool.getMaxSize() &&
> active >= MIN_ACTIVE_RATIO * total) {
> ConnectionContext conn = pool.newConnection();
> pool.addConnection(conn);
> } else {
> LOG.debug("Cannot add more than {} connections to {}",
> pool.getMaxSize(), pool);
> }
> {code}
> It affects cleanup and creating Connections. Maybe it should be configurable
> so that we can reconfig it to improve performance
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
