[ 
https://issues.apache.org/jira/browse/HDDS-889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714473#comment-16714473
 ] 

Elek, Marton commented on HDDS-889:
-----------------------------------

Hi, I would like to continue with the review of this one but it doesn't apply 
any more. Could you please rebase for me?

 

OFF: I tried to apply it to an old branch but didn't succeed. I am just 
wondering how can it be handled to make it possible to apply in-dependent from 
the current state of the trunk (I would be happy to start the review even on 
top of an older commit)

One option could be to create different type of patches. AFAIK with git 
format-patch we can include multiple commits in one patch together with the 
parent commit and parent information. I didn't test it but with this option I 
think it could be uploaded together with (an uncommitted) dependency.

The other option is to use github pull requests where the full branch is 
available (with additional advantages such as propose small changes instead of 
commenting)

Don't know what is the best, but I had exactly the same problem with the 
strongly typed patch line...

 

 

> MultipartUpload: Support uploading a part file in ozone
> -------------------------------------------------------
>
>                 Key: HDDS-889
>                 URL: https://issues.apache.org/jira/browse/HDDS-889
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Major
>         Attachments: HDDS-889.01.patch
>
>
> This Jira is to track the work required to create an API in Client to create 
> an part file during multipart upload. 
> This Jira does following changes:
>  # Add a new API in ClientProtocol.java createMultipartKey which creates a 
> multipart key.
>  # In Om End add a new API to commitMultipartUploadPart similar to commit for 
> key, here we commit the part key of a multipart upload. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to