[
https://issues.apache.org/jira/browse/HDFS-14101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714982#comment-16714982
]
Sean Mackrory commented on HDFS-14101:
--------------------------------------
+1, thanks Zsolt. I think the shared variable is an improvement, but I still
think it's worth a comment, so I'm gonna add the following add the declaration
of corruptionLength if no one objects:
{code}
// Files are corrupted with 2 bytes before the end of the file,
// so that's the minimum length
{code}
Of course, as I understand it, there's still a 1:65,536 chance the corruption
isn't detected because the random bytes we overwrite with are identical to
those that were there originally, but this is a step in the right direction :)
> Random failure of testListCorruptFilesCorruptedBlock
> ----------------------------------------------------
>
> Key: HDFS-14101
> URL: https://issues.apache.org/jira/browse/HDFS-14101
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: test
> Affects Versions: 3.2.0, 3.0.3, 2.8.5
> Reporter: Kihwal Lee
> Assignee: Zsolt Venczel
> Priority: Major
> Labels: newbie
> Attachments: HDFS-14101.01.patch, HDFS-14101.02.patch
>
>
> We've seen this occasionally.
> {noformat}
> java.lang.IllegalArgumentException: Negative position
> at sun.nio.ch.FileChannelImpl.write(FileChannelImpl.java:755)
> at org.apache.hadoop.hdfs.server.namenode.
>
> TestListCorruptFileBlocks.testListCorruptFilesCorruptedBlock(TestListCorruptFileBlocks.java:105)
> {noformat}
> The test has a flaw.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
