[ 
https://issues.apache.org/jira/browse/HDDS-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16719151#comment-16719151
 ] 

Dinesh Chitlangia edited comment on HDDS-914 at 12/12/18 4:49 PM:
------------------------------------------------------------------

[~elek] Thanks for reviewing the patch.

Comments #1 & #2 have been addressed.

Regarding #3
{quote}I am not sure if it's a good idea to add promethes + grafana to *all* 
the docker-compose clusters.
{quote}
When I now look back, I think it makes sense to add grafana+prometheus only to 
ozoneperf.

I even verified by using the docker clusters, it does take a lot of resources 
and my laptop fan was fairly audible!

I can still leave the related configs file under ~/compose/common for ease of 
maintainability.

 

Let me know your thoughts and then I will upload a new patch with all the 
changes.


was (Author: dineshchitlangia):
[~elek] Thanks for reviewing the patch.

Comments #1 & #2 have been addressed.

Regarding #3
{quote}I am not sure if it's a good idea to add promethes + grafana to *all* 
the docker-compose clusters.
{quote}
When I now look back, I think it makes sense to add grafana+prometheus only to 
ozoneperf.

I can still leave the related configs file under ~/compose/common for ease of 
maintainability.

 

Let me know your thoughts and then I will upload a new patch with all the 
changes.

> Add Grafana support to docker containers
> ----------------------------------------
>
>                 Key: HDDS-914
>                 URL: https://issues.apache.org/jira/browse/HDDS-914
>             Project: Hadoop Distributed Data Store
>          Issue Type: New Feature
>          Components: docker
>            Reporter: Dinesh Chitlangia
>            Assignee: Dinesh Chitlangia
>            Priority: Major
>         Attachments: HDDS-914.001.patch
>
>
> Since we are using Prometheus as a datasource to capture metrics from OM & 
> SCM, it will be useful to have basic Grafana Dashboards made available once 
> we start the docker cluster.
> This will be useful for investigation/analysis.
>  
> This Jira proposes to have grafana + prometheus support for following docker 
> containers under ~/compose:
> ozone, ozone-hdfs, ozonefs, ozoneperf, ozones3
>  
> This Jira will also add 2 simple ozone dashboards - Basic Object Creations 
> stats, RPC Metrics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to