[
https://issues.apache.org/jira/browse/HDDS-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16719259#comment-16719259
]
Ajay Kumar commented on HDDS-115:
---------------------------------
[~xyao] thanks for working on this. LGTM
Few minor comments:
HDFSConfigKeys
L150: This might be subjective but shall we rename CERTIFICATE_COLLECTION to
TRUST_STORE or TRUST_MANAGER ( i think collection file is not commonly used)?
Ozone-default.xml
New configs are not included in it.
TestOzoneContainerWithTLS
Shall we add a negative test case where tls auth failure is asserted?
TestSecureOzoneCluster
L355 Lets remove the commented line if its not required.
> GRPC: Support secure gRPC endpoint with mTLS
> ---------------------------------------------
>
> Key: HDDS-115
> URL: https://issues.apache.org/jira/browse/HDDS-115
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Xiaoyu Yao
> Assignee: Xiaoyu Yao
> Priority: Major
> Attachments: HDDS-115-HDDS-4.001.patch, HDDS-115-HDDS-4.002.patch,
> HDDS-115-HDDS-4.003.patch, HDDS-115-HDDS-4.004.patch,
> HDDS-115-HDDS-4.005.patch, HDDS-115-HDDS-4.006.patch,
> HDDS-115-HDDS-4.008.patch, HDDS-115-HDDS-4.009.patch,
> HDDS-115-HDDS-4.010.patch, HDDS-115-HDDS-4.011.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
