[
https://issues.apache.org/jira/browse/HDFS-13873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantin Shvachko updated HDFS-13873:
---------------------------------------
Status: Patch Available (was: Open)
Thanks for the review Erik.
??Javadoc description, for the new parameter on {{#receiveRequestState()}} do
not match??
The idea is to make this parameter as generic as possible in
{{AlignmentContext}} and clarify its usage in the implementation
{{GlobalStateIdContext}}. We will probably put more subtle logic for the
no-wait condition, so I want to keep {{AlignmentContext}} description generic.
??adding a new package-private method setLastSeenStateIdForTest()??
Using mocks and reflections in tests is fine. Adding a setter in an API, when
the field is not supposed to be modified from the outside is a bad practice.
Even if its name says "ForTesting".
Fixed all other comments. Mostly cosmetic changes, but let Jenkins run.
> ObserverNode should reject read requests when it is too far behind.
> -------------------------------------------------------------------
>
> Key: HDFS-13873
> URL: https://issues.apache.org/jira/browse/HDFS-13873
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client, namenode
> Affects Versions: HDFS-12943
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Priority: Major
> Attachments: HDFS-13873-HDFS-12943.001.patch,
> HDFS-13873-HDFS-12943.002.patch, HDFS-13873-HDFS-12943.003.patch,
> HDFS-13873-HDFS-12943.004.patch
>
>
> Add a server-side threshold for ObserverNode to reject read requests when it
> is too far behind.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
