[
https://issues.apache.org/jira/browse/HDFS-1779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098812#comment-13098812
]
Jitendra Nath Pandey commented on HDFS-1779:
--------------------------------------------
A few comments:
TestAppend.java:
# I will recommend to rename the class to something like TestBBWBlockReport.
# Please use cluster.restartNameNode() instead of private restartNamenode.
# Can we avoid making dfs, namenode, outStream etc as class fields.
# In tearDown, namenode.stop is not required because cluster.shutdown takes
care of it.
# outStream.close will likely fail after
testDNShouldNotSendBBWReportIfAppendOff because namenode will be in safemode.
# waitFor method can be replaced with Thread.sleep.
> After NameNode restart , Clients can not read partial files even after client
> invokes Sync.
> -------------------------------------------------------------------------------------------
>
> Key: HDFS-1779
> URL: https://issues.apache.org/jira/browse/HDFS-1779
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: data-node, name-node
> Affects Versions: 0.20-append
> Environment: Linux
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Fix For: 0.20-append, 0.20.205.0
>
> Attachments: HDFS-1779.1.patch, HDFS-1779.2.patch, HDFS-1779.patch,
> bbwReportAppend.patch
>
>
> In Append HDFS-200 issue,
> If file has 10 blocks and after writing 5 blocks if client invokes sync
> method then NN will persist the blocks information in edits.
> After this if we restart the NN, All the DataNodes will reregister with NN.
> But DataNodes are not sending the blocks being written information to NN. DNs
> are sending the blocksBeingWritten information in DN startup. So, here
> NameNode can not find that the 5 persisted blocks belongs to which datanodes.
> This information can build based on block reports from DN. Otherwise we will
> loose this 5 blocks information even NN persisted that block information in
> edits.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
