[ 
https://issues.apache.org/jira/browse/HDDS-539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16722686#comment-16722686
 ] 

Shashikant Banerjee commented on HDDS-539:
------------------------------------------

Thanks [~vmurakami] for updating the patch. Some tests are failing with the 
following 
{code:java}
[ERROR] testDNstartAfterSCM(org.apache.hadoop.ozone.TestMiniOzoneCluster)  Time 
elapsed: 5.8 s  <<< ERROR!
java.lang.NullPointerException
        at 
org.apache.hadoop.ozone.HddsDatanodeService.createHddsDatanodeService(HddsDatanodeService.java:106)
        at 
org.apache.hadoop.ozone.HddsDatanodeService.createHddsDatanodeService(HddsDatanodeService.java:90)
        at 
org.apache.hadoop.ozone.MiniOzoneClusterImpl.restartHddsDatanode(MiniOzoneClusterImpl.java:272)
        at 
org.apache.hadoop.ozone.TestMiniOzoneCluster.testDNstartAfterSCM(TestMiniOzoneCluster.java:239)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
        at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
        at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
        at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
        at 
org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74){code}
It seems to be related to the patch. Can you please check?

> ozone datanode ignores the invalid options
> ------------------------------------------
>
>                 Key: HDDS-539
>                 URL: https://issues.apache.org/jira/browse/HDDS-539
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>            Reporter: Namit Maheshwari
>            Assignee: Vinicius Higa Murakami
>            Priority: Major
>              Labels: newbie
>         Attachments: HDDS-539.003.patch, HDDS-539.004.patch, 
> HDDS-539.005.patch, HDDS-539.006.patch, HDDS-539.007.patch, 
> HDDS-539.008.patch, HDDS-539.009.patch, HDDS-539.patch
>
>
> ozone datanode command starts datanode and ignores the invalid option, apart 
> from help
> {code:java}
> [root@ctr-e138-1518143905142-481027-01-000002 bin]# ./ozone datanode -help
> Starts HDDS Datanode
> {code}
> For all the other invalid options, it just ignores and starts the DN like 
> below:
> {code:java}
> [root@ctr-e138-1518143905142-481027-01-000002 bin]# ./ozone datanode -ABC
> 2018-09-22 00:59:34,462 [main] INFO - STARTUP_MSG:
> /************************************************************
> STARTUP_MSG: Starting HddsDatanodeService
> STARTUP_MSG: host = 
> ctr-e138-1518143905142-481027-01-000002.hwx.site/172.27.54.20
> STARTUP_MSG: args = [-ABC]
> STARTUP_MSG: version = 3.2.0-SNAPSHOT
> STARTUP_MSG: classpath = 
> /root/ozone-0.3.0-SNAPSHOT/etc/hadoop:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/commons-cli-1.2.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/kerb-crypto-1.0.1.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/guava-11.0.2.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/hadoop-auth-3.2.0-SNAPSHOT.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/jcip-annotations-1.0-1.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/jsr305-3.0.0.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/commons-compress-1.4.1.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/commons-beanutils-1.9.3.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/jackson-core-asl-1.9.13.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/jackson-jaxrs-1.9.13.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/commons-collections-3.2.2.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/jsp-api-2.1.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/kerb-simplekdc-1.0.1.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/htrace-core4-4.1.0-incubating.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/zookeeper-3.4.9.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/gson-2.2.4.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/token-provider-1.0.1.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/dnsjava-2.1.7.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/jaxb-impl-2.2.3-1.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/avro-1.7.7.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/jsr311-api-1.1.1.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/jersey-json-1.19.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/stax2-api-3.1.4.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/log4j-1.2.17.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/accessors-smart-1.2.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/commons-lang3-3.7.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/jersey-server-1.19.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/netty-3.10.5.Final.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/snappy-java-1.0.5.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/kerby-config-1.0.1.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/kerby-util-1.0.1.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/httpclient-4.5.2.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/jetty-security-9.3.19.v20170502.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/hadoop-annotations-3.2.0-SNAPSHOT.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/re2j-1.1.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/jackson-databind-2.9.5.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/commons-math3-3.1.1.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/commons-logging-1.1.3.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/jersey-core-1.19.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/kerb-client-1.0.1.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/jsch-0.1.54.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/jersey-servlet-1.19.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/asm-5.0.4.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/jackson-core-2.9.5.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/jetty-util-9.3.19.v20170502.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/slf4j-log4j12-1.7.25.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/nimbus-jose-jwt-4.41.1.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/kerb-core-1.0.1.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/json-smart-2.3.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/commons-io-2.5.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/commons-codec-1.11.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/jackson-mapper-asl-1.9.13.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/commons-configuration2-2.1.1.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/commons-text-1.4.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/paranamer-2.3.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/kerb-identity-1.0.1.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/commons-net-3.6.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/xz-1.0.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/woodstox-core-5.0.3.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/jettison-1.1.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/kerb-common-1.0.1.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/curator-framework-2.12.0.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/jetty-server-9.3.19.v20170502.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/jetty-webapp-9.3.19.v20170502.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/kerb-admin-1.0.1.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/jetty-http-9.3.19.v20170502.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/jetty-xml-9.3.19.v20170502.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/javax.servlet-api-3.1.0.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/jetty-servlet-9.3.19.v20170502.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/kerby-pkix-1.0.1.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/kerb-util-1.0.1.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/jaxb-api-2.2.11.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/kerby-xdr-1.0.1.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/jackson-annotations-2.9.5.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/httpcore-4.4.4.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/protobuf-java-2.5.0.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/jackson-xc-1.9.13.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/kerby-asn1-1.0.1.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/kerb-server-1.0.1.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/curator-recipes-2.12.0.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/jetty-io-9.3.19.v20170502.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/slf4j-api-1.7.25.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/lib/curator-client-2.12.0.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/common/hadoop-common-3.2.0-SNAPSHOT.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/ozone:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/auto-service-1.0-rc4.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/bcpkix-jdk15on-1.54.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/netty-all-4.0.52.Final.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/netty-tcnative-2.0.8.Final-osx-x86_64.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/jetty-util-ajax-9.3.19.v20170502.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/aalto-xml-1.0.0.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/hadoop-hdfs-client-3.2.0-SNAPSHOT.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/ratis-netty-0.3.0-eca3531-20180918.052321-2.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/okhttp-2.7.5.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/bcprov-jdk15on-1.54.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/snakeyaml-1.8.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/jzlib-1.1.3.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/jctools-core-2.1.2.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/jboss-marshalling-1.4.11.Final.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/auto-value-annotations-1.6.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/compress-lzf-1.0.3.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/sqlite-jdbc-3.8.7.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/javapoet-1.10.0.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/animal-sniffer-annotations-1.16.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/hadoop-hdds-client-0.3.0-SNAPSHOT.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/rocksdbjni-5.14.2.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/hamcrest-all-1.3.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/error_prone_annotations-2.2.0.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/auto-value-1.6.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/ratis-grpc-0.3.0-eca3531-20180918.052238-2.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/log4j-api-2.11.0.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/snakeyaml-1.16.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/log4j-core-2.11.0.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/hadoop-hdds-container-service-0.3.0-SNAPSHOT.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/okio-1.6.0.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/picocli-3.5.2.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/j2objc-annotations-1.3.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/leveldbjni-all-1.8.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/metrics-core-3.2.4.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/ratis-proto-shaded-0.3.0-eca3531-20180918.051334-1.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/commons-pool2-2.6.0.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/ratis-common-0.3.0-eca3531-20180918.052022-2.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/hadoop-hdfs-3.2.0-SNAPSHOT.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/ratis-server-0.3.0-eca3531-20180918.052141-2.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/commons-daemon-1.0.13.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/lz4-1.3.0.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/disruptor-3.4.2.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/ratis-client-0.3.0-eca3531-20180918.052108-2.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/lib/auto-common-0.8.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/hadoop-hdds-server-scm-0.3.0-SNAPSHOT.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/hadoop-hdds-tools-0.3.0-SNAPSHOT.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/hadoop-hdds-server-framework-0.3.0-SNAPSHOT.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/hdds/hadoop-hdds-common-0.3.0-SNAPSHOT.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/ozone/lib/jmh-generator-annprocess-1.19.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/ozone/lib/jmh-core-1.19.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/ozone/lib/hadoop-ozone-client-0.3.0-SNAPSHOT.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/ozone/lib/jopt-simple-4.6.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/ozone/hadoop-ozone-tools-0.3.0-SNAPSHOT.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/ozone/hadoop-ozone-objectstore-service-0.3.0-SNAPSHOT.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/ozone/hadoop-ozone-ozone-manager-0.3.0-SNAPSHOT.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/ozone/hadoop-ozone-common-0.3.0-SNAPSHOT.jar:/root/ozone-0.3.0-SNAPSHOT/share/hadoop/ozonefs/hadoop-ozone-filesystem-0.3.0-SNAPSHOT.jar
> STARTUP_MSG: build = g...@github.com:apache/hadoop.git -r 
> a2752779ac1545f5e0a52fce3cff02a7007e95fb; compiled by 'nmaheshwari' on 
> 2018-09-21T10:48Z
> STARTUP_MSG: java = 1.8.0_112
> ************************************************************/
> 2018-09-22 00:59:34,490 [main] INFO - registered UNIX signal handlers for 
> [TERM, HUP, INT]
> 2018-09-22 00:59:34,719 INFO impl.MetricsConfig: Loaded properties from 
> hadoop-metrics2.properties
> 2018-09-22 00:59:34,875 INFO impl.MetricsSystemImpl: Scheduled Metric 
> snapshot period at 10 second(s).
> 2018-09-22 00:59:34,875 INFO impl.MetricsSystemImpl: HddsDatanode metrics 
> system started
> 2018-09-22 00:59:34,925 INFO Configuration.deprecation: No unit for 
> ozone.scm.heartbeat.rpc-timeout(1000) assuming MILLISECONDS
> 2018-09-22 00:59:34,941 INFO Configuration.deprecation: No unit for 
> hdds.write.lock.reporting.threshold.ms(5000) assuming MILLISECONDS
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to