[
https://issues.apache.org/jira/browse/HDDS-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723463#comment-16723463
]
Ajay Kumar edited comment on HDDS-102 at 12/17/18 11:26 PM:
------------------------------------------------------------
[~anu] thanks for the important patch. LGTM. Some additional comments from what
[~xyao] has already mentioned:
KeyCodec
L213/258 Specify the security provider as well? (i.e BC)
L238 readPublicKey: Shall we read public key first time form file and than
cache it for further purposes?
DefaultApprover
Method sign Shall we add documentation to ensure users call approver#validate
before it.
DefaultCAServer
L139: Typo "configureable"
package-info
L76: Possible typo "The last, and method which never"
L78 "CSR is the base" perhaps "is" should be replaced with "if"?
TestDefaultCAServer
Unused imports
L168 Shall we validate the received certificate? (signature etc)
TestDefaultProfile
Add a TODO for unimplemented test cases?
was (Author: ajayydv):
[~anu] thanks for the important patch. LGTM. Some additional comments from what
[~xyao] has already mentioned:
KeyCodec
L213/258 Specify the security provider as well? (i.e BC)
L238 readPublicKey: Shall we read public key first time form file and than
cache it for further purposes?
DefaultApprover
Method sign Shall we add documentation to ensure users call approver#validate
before it.
DefaultCAServer
L139: Typo "configureable"
L62 should be
package-info
L76: Possible typo "The last, and method which never"
L78 "CSR is the base" perhaps "is" should be replaced with "if"?
TestDefaultCAServer
Unused imports
L168 Shall we validate the received certificate? (signature etc)
TestDefaultProfile
Add a TODO for unimplemented test cases?
> SCM CA: SCM CA server signs certificate for approved CSR
> --------------------------------------------------------
>
> Key: HDDS-102
> URL: https://issues.apache.org/jira/browse/HDDS-102
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Xiaoyu Yao
> Assignee: Anu Engineer
> Priority: Major
> Attachments: HDDS-102-HDDS-4.001.patch, HDDS-102-HDDS-4.001.patch,
> HDDS-102-HDDS-4.002.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
