[
https://issues.apache.org/jira/browse/HDDS-881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16724183#comment-16724183
]
Arpit Agarwal commented on HDDS-881:
------------------------------------
Thanks [~hanishakoneru]. The patch looks pretty good.
I didn't see Mukul's +1 until I finished reviewing so posting my comments
anyway. Just a few points, mostly nitpicks except for 1 and 2:
# OzoneManagerProtocolClientSideTranslatorPB. {{@throws IOException}} seems to
be incorrectly removed from javadoc of multiple functions.
# OzoneManagerProtocolClientSideTranslatorPB.listKeys: Just curious why the
{{if (resp == null)}} check was added. can ListKeys return a null response? The
check is not there for other request types.
# OzoneManagerProtocolClientSideTranslatorPB - omResponse field appears to be
unnecessary in most places. Can remove that line to make all the calls slightly
more concise.
{code}
E.g. CreateVolumeResponse resp =
submitRequest(omRequest).getCreateVolumeResponse();
{code}
# OzoneManagerProtocolClientSideTranslatorPB:700 - reformatting looks
unnecessary. The line was easier to read before. There seems to be some
unnecessary reformatting in general - lines not exceeding 80 chars limit were
broken up.
# resp and response are a little confusing. Can you give them different names?
{code}
MultipartInfoInitiateResponse resp = omResponse
.getInitiateMultiPartUploadResponse();
MultipartCommitUploadPartResponse response = omResponse
.getCommitMultiPartUploadResponse();
{code}
> Encapsulate all client to OM requests into one request message
> --------------------------------------------------------------
>
> Key: HDDS-881
> URL: https://issues.apache.org/jira/browse/HDDS-881
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Hanisha Koneru
> Assignee: Hanisha Koneru
> Priority: Major
> Attachments: HDDS-881.001.patch, HDDS-881.002.patch,
> HDDS-881.003.patch, HDDS-881.004.patch, HDDS-881.005.patch,
> HDDS-881.006.patch, HDDS-881.007.patch
>
>
> When OM receives a request, we need to transform the request into Ratis
> server compatible request so that the OM's Ratis server can process that
> request.
> In this Jira, we just add the support to convert a client request received by
> OM into a RaftClient request. This transformed request would later be passed
> onto the OM's Ratis server.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
