[ https://issues.apache.org/jira/browse/HDDS-929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16724542#comment-16724542 ]
Anu Engineer commented on HDDS-929: ----------------------------------- When I apply this patch and run tests locally I get a large number of failures. {code} com.google.protobuf.UninitializedMessageException: Message missing required fields: maxKeyLen at com.google.protobuf.AbstractMessage$Builder.newUninitializedMessageException(AbstractMessage.java:770) at org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos$SecretKeyProto$Builder.build(OzoneManagerProtocolProtos.java:30185) at org.apache.hadoop.ozone.security.OzoneSecretKey.write(OzoneSecretKey.java:110) {code} Can you please take a quick look? There is also a set of ErrorProne errors in the HDDS-4 branch from earlier code patches that got committed, I will post a patch here that you can incorporate to your changes if needed. > Remove ozone.max.key.len property > ---------------------------------- > > Key: HDDS-929 > URL: https://issues.apache.org/jira/browse/HDDS-929 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Reporter: Ajay Kumar > Assignee: Ajay Kumar > Priority: Major > Attachments: HDDS-929-HDDS-4.00.patch > > > Generation of secret key in OzoneSecretManager is different from hadoop > SecretManager. Since key-pair generation is not the responsibility of > {{OzoneSecretManager}}/{{OzoneSecretKey}} we don't need maxKeyLen related > checks inside them. Jira proposes to remove ozone.max.key.len. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org