[ 
https://issues.apache.org/jira/browse/HDFS-14154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725200#comment-16725200
 ] 

Erik Krogen commented on HDFS-14154:
------------------------------------

Hey Chao, thanks for tackling this. You have one typo, "cingure" should be 
"configure". The recommendation about {{dfs.ha.tail-edits.period}} looks great 
to me and I appreciate you taking care of it. I wonder if it might sound better 
with passive voice, i.e., "It is highly recommended to configure..." rather 
than "We highly recommend to configure..." but I'll leave it up to you. I am 
also wondering if 100ms is the right recommendation -- I would have probably 
picked a lower value between 0ms and 10ms, but am curious if you have any 
reasoning behind your choice, particularly if it is based off of any issues 
encountered with a lower period. In my testing to benchmark HDFS-13150 feature 
I believe I kept it at 0ms without any issues.

> Document dfs.ha.tail-edits.period in user guide.
> ------------------------------------------------
>
>                 Key: HDFS-14154
>                 URL: https://issues.apache.org/jira/browse/HDFS-14154
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: documentation
>            Reporter: Chao Sun
>            Assignee: Chao Sun
>            Priority: Major
>         Attachments: HDFS-14154-HDFS-12943.000.patch
>
>
> We should document {{dfs.ha.tail-edits.period}} in the user guide. The 
> default value is too large for {{ObserverReadProxyProvider}} and we should 
> recommend a value.
> We can also address some remaining issues in HDFS-14131.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to