[
https://issues.apache.org/jira/browse/HDFS-13856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16726957#comment-16726957
]
Íñigo Goiri commented on HDFS-13856:
------------------------------------
Thanks [~ferhui] for [^HDFS-13856-HDFS-13891.001.patch].
Minor comments:
* Avoid the extra line in the imports of {{RouterAdmin}}.
* In {{RouterAdmin#970}} no need for semi colon.
* Kind of weird the way {{genericRefresh}} shows the error in the finally. One
could also do the returns directly without storing it in {{returnCode}}.
* Avoid last line change in {{RouterAdmin}}.
* I would add a simple test to the {{TestRouterAdminCLI}}.
* Add this to the documentation and the command definition (e.g., md files and
help).
As I mentioned before, I'm not super familiar with this feature so it would be
good if somebody else can take a look at it.
> RBF: RouterAdmin should support dfsrouteradmin -refresh command
> ---------------------------------------------------------------
>
> Key: HDFS-13856
> URL: https://issues.apache.org/jira/browse/HDFS-13856
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: federation, hdfs
> Affects Versions: 3.0.0, 3.1.0, 2.9.1
> Reporter: yanghuafeng
> Assignee: yanghuafeng
> Priority: Major
> Attachments: HDFS-13856-HDFS-13891.001.patch, HDFS-13856.001.patch,
> HDFS-13856.002.patch
>
>
> Like namenode router should support refresh policy individually. For example,
> we have implemented simple password authentication per rpc connection. The
> password dict can be refreshed by generic refresh policy. We also want to
> support this in RouterAdminServer.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
