[
https://issues.apache.org/jira/browse/HDFS-14169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728309#comment-16728309
]
Surendra Singh Lilhore commented on HDFS-14169:
-----------------------------------------------
{quote}If we didn't get it.we are say sending back number of stale datanodes to
be 0.Which is valid.Will it not develop a wrong perspective? The person
fetching it will consider it to be true and won't dig up further. Always
believed send it correct or don't send it. And How come a Disclaimer is a valid
result?
{quote}
Metrics are just system statics, it gives correct info when system is fully
functional. It is not used for fault detection (like return -1 in case of
exception).
Anyway metrics system get exception only when system is not fully initialized
or actual bug is there in code, which we should fix.
{quote}Somewhere -1 Somewhere 0.It's just confusing.We should consider making
it little consistent.When we don't have it we send the default 0.
{quote}
Yes, if any counter metrics returning -1 then we should change it to 0.
> RBF: Correct the returned value in case of IOException in
> NamenodeBeanMetrics#getFederationMetrics
> --------------------------------------------------------------------------------------------------
>
> Key: HDFS-14169
> URL: https://issues.apache.org/jira/browse/HDFS-14169
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Attachments: HDFS-14169-HDFS-13891-01.patch
>
>
> Presently in case of IOException the the metrics value returned is 0 which is
> a legal entry.Better to change to a value which could indicate that the value
> hasn't been actually fetched.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
