[
https://issues.apache.org/jira/browse/HDDS-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16732421#comment-16732421
]
Anu Engineer commented on HDDS-938:
-----------------------------------
[~dineshchitlangia] Thanks for getting this done. Overall, the patch looks very
good to me. Some very minor comments. I will commit this as soon as these
comments are taken care off.
# *OmUtils.java#getMD5Digest/getShaDigest* - While is it is almost impossible
for a setup not to have MD5 algorithm, I think we should just throw that back
to the user than catch and ignore it. It generally indicates a faulty JRE.
# nit*: OzoneManager.java#getS3Secret*, missing java doc for this function,
feel free to inherit the doc if possible.
# For future - Let us file a JIRA for this. We need to verify that Kerberos
user ID is same the caller identity when *getS3Secert* call is made. No other
user should be permitted to read a users ID.
# *S3SecretManagerImpl.java#getS3Secre*t, we should do the same check we do in
the RPC client, that is verify that kerberosID is not blank.
> Add Client APIs for using S3 Auth interface
> -------------------------------------------
>
> Key: HDDS-938
> URL: https://issues.apache.org/jira/browse/HDDS-938
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: S3
> Reporter: Anu Engineer
> Assignee: Dinesh Chitlangia
> Priority: Major
> Attachments: HDDS-938-HDDS-4.00.patch, HDDS-938-HDDS-4.01.patch
>
>
> Add Client and Server APIs to access the S3 Auth interface supported by Ozone
> Manager.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
