[
https://issues.apache.org/jira/browse/HDDS-896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734054#comment-16734054
]
Nanda kumar commented on HDDS-896:
----------------------------------
Thanks [~anu] for the review.
>> ReplicaManager.java: Add some info traces when we start delete/replica
>> operations? It is kind of useful to have these statements in the log.
Added log statements.
>> nit: ReplicaManager.java: There are some classes that has a Java doc comment
>> that says – Add JavaDoc.
Fixed.
>> The time that we collect in CloseContainerCommandHandler.java, it might be
>> good to report back to SCM. That way we can build a average time to close
>> and std.dev etc for this operation. Same comment for other commands in the
>> DN.
Good idea. Created HDDS-961 to track it.
>> Is it possible for the SCM to be confused and send conflicting commands to a
>> DN. For example, what happens if I send – CloseContainer, ReplicateContainer
>> and DeleteContainer together? Is the data node guaranteed to process only
>> one command at a time? should we introduce the same kind of locking that we
>> have in SCM inside a datanode?
Good catch, it is better to have a proper locking logic here. Created HDDS-962
for tracking this.
> Handle over replicated containers in SCM
> ----------------------------------------
>
> Key: HDDS-896
> URL: https://issues.apache.org/jira/browse/HDDS-896
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: SCM
> Reporter: Nanda kumar
> Assignee: Nanda kumar
> Priority: Major
> Attachments: HDDS-896.000.patch, HDDS-896.001.patch,
> HDDS-896.002.patch
>
>
> When SCM detects that a container is over-replicated, it has to delete some
> replicas to bring the number of replicas to match the required value. If the
> container is in QUASI_CLOSED state, we should check the {{originNodeId}}
> field while choosing the replica to delete.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
