[
https://issues.apache.org/jira/browse/HDDS-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734658#comment-16734658
]
Hanisha Koneru commented on HDDS-915:
-------------------------------------
Thank you [~anu].
{quote}bq. Not sure I understand this change, in OzoneManagerProtocol.proto,
we make cmdType from required to optional. Is there a reason to do it? or just
generally following good practices of protobuf. Optional is preferred over
required in many cases.
{quote}
I had made this change to accommodate error responses in case there is an
exception while parsing the request. But we do not need this change. I have
made changes so that the RaftClientReply contains the exception instead.
I have addressed the other two comments and fixed checkstyle and unit test
failures in patch v03.
> Submit client request to OM Ratis server
> ----------------------------------------
>
> Key: HDDS-915
> URL: https://issues.apache.org/jira/browse/HDDS-915
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Hanisha Koneru
> Assignee: Hanisha Koneru
> Priority: Major
> Attachments: HDDS-915.001.patch, HDDS-915.002.patch,
> HDDS-915.003.patch
>
>
> OM ratis client should submit incoming client request to the ratis server. OM
> should distinguish read requests and write requests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
