[
https://issues.apache.org/jira/browse/HDFS-14103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735775#comment-16735775
]
Ayush Saxena commented on HDFS-14103:
-------------------------------------
Thanks [~belugabehr] for working on it.
One minor doubt I guess, here it would be redundant logging
{code:java}
427 LOG.trace(message, e);
428 LOG.warn(message + " " + e.getMessage());
{code}
Before it was logging warn only if trace wasn't enabled.
Now it will log even if it is enabled too.
Other than this!! Patch Looks Good
> Review Logging of BlockPlacementPolicyDefault
> ---------------------------------------------
>
> Key: HDFS-14103
> URL: https://issues.apache.org/jira/browse/HDFS-14103
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Minor
> Attachments: HDFS-14103.1.patch, HDFS-14103.1.patch
>
>
> Review use of SLF4J in {{BlockPlacementPolicyDefault.java}}
> Other minor logging improvements.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
