[
https://issues.apache.org/jira/browse/HDDS-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736361#comment-16736361
]
Ajay Kumar commented on HDDS-597:
---------------------------------
[~xyao] thanks for the patch. LGTM, few comments:
* SecurityConfig
** Mutual tls via getClientPrivateKeyFile and getClientCertChainFile may not
work for multiple clients running in same machine as they may return same file.
* XceiverServerRatis
** L46 unused import
** L351: We already check if grpc tls is enabled inside
RatisHelper#createTlsServerConfig
* Shall we add a negative test for tls check based on some dummy/expired
certificate.
> Ratis: Support secure gRPC endpoint with mTLS for Ratis
> -------------------------------------------------------
>
> Key: HDDS-597
> URL: https://issues.apache.org/jira/browse/HDDS-597
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Xiaoyu Yao
> Assignee: Xiaoyu Yao
> Priority: Major
> Attachments: HDDS-597-HDDS-4.001.patch, HDDS-597-HDDS-4.002.patch,
> HDDS-597-HDDS-4.003.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
