[
https://issues.apache.org/jira/browse/HDDS-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736800#comment-16736800
]
Shashikant Banerjee commented on HDDS-947:
------------------------------------------
Thanks [~hanishakoneru] for updating the patch. The patch overall looks good to
me. Some comments inline:
1. OzoneManagerRatisServer.java : 207 -> The comments related to putSmallFile
seems to be misleading. PutSmallFiile request will not be handled by
OzoneManagerRequestHandler.
2. OzoneManagerRatisServer.java : 270-290 -> The changes related to config for
setting stateMachineData related configs are not required as there is no
support for "writeStateMachineData" in OzoneManagerStateMachine.
3. Similarly, configs related to stateMachineData as mentioned above should be
removed from Ozone-Default.xml and OMConfigKeys.
4. OzoneManagerStateMachine.java : Line 80-82 can be clubbed together in a
single statement.
5. OzoneManagerStateMachine.java should implement "startTransaction" call for
BaseStateMachine. Refer to ContainerStateMachine for this.
> Implement OzoneManager State Machine
> ------------------------------------
>
> Key: HDDS-947
> URL: https://issues.apache.org/jira/browse/HDDS-947
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Hanisha Koneru
> Assignee: Hanisha Koneru
> Priority: Major
> Attachments: HDDS-947.000.patch, HDDS-947.001.patch,
> HDDS-947.002.patch, HDDS-947.003.patch
>
>
> OM Ratis server would call OM State Machine to apply the committed
> transactions. The State Machine processes the transaction and updates the
> state of OzoneManager.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
