[ 
https://issues.apache.org/jira/browse/HDFS-14061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737125#comment-16737125
 ] 

Kitti Nanasi commented on HDFS-14061:
-------------------------------------

Thanks for the comment [~adam.antal]!

I fixed the renames and added a new test.

The new message is already tested in TestECAdmin, so I don't think it would add 
more value to also test it in TestErasureCodingCLI, and the number of racks and 
data nodes are more difficult to configure there.

You are right, System.err in TestECAdmin.java was only used by patch v001, but 
I think it is worth to keep that check, because ECAdmin can write to System.err.

> Check if the cluster topology supports the EC policy before setting, enabling 
> or adding it
> ------------------------------------------------------------------------------------------
>
>                 Key: HDFS-14061
>                 URL: https://issues.apache.org/jira/browse/HDFS-14061
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: erasure-coding, hdfs
>    Affects Versions: 3.1.1
>            Reporter: Kitti Nanasi
>            Assignee: Kitti Nanasi
>            Priority: Major
>         Attachments: HDFS-14061.001.patch, HDFS-14061.002.patch, 
> HDFS-14061.003.patch
>
>
> HDFS-12946 introduces a command for verifying if there are enough racks and 
> datanodes for the enabled erasure coding policies.
> This verification could be executed for the erasure coding policy before 
> enabling, setting or adding it and a warning message could be written if the 
> verify fails, or the policy setting could be even failed in this case.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to