[ 
https://issues.apache.org/jira/browse/HDFS-14061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737407#comment-16737407
 ] 

Shweta edited comment on HDFS-14061 at 1/8/19 6:48 PM:
-------------------------------------------------------

Thanks for the patch [~knanasi]. Looks good to me.
Just a small improvement would be to add messages for assertEquals() for it to 
be more descriptive in any case of failure.

Apart from that +1 (Non-binding).


was (Author: shwetayakkali):
Thanks for the patch [~knanasi]. Looks good to me.
Just a small improvement would be to add messages for assertEquals() for it to 
be more descriptive.

Apart from that +1 (Non-binding).

> Check if the cluster topology supports the EC policy before setting, enabling 
> or adding it
> ------------------------------------------------------------------------------------------
>
>                 Key: HDFS-14061
>                 URL: https://issues.apache.org/jira/browse/HDFS-14061
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: erasure-coding, hdfs
>    Affects Versions: 3.1.1
>            Reporter: Kitti Nanasi
>            Assignee: Kitti Nanasi
>            Priority: Major
>         Attachments: HDFS-14061.001.patch, HDFS-14061.002.patch, 
> HDFS-14061.003.patch
>
>
> HDFS-12946 introduces a command for verifying if there are enough racks and 
> datanodes for the enabled erasure coding policies.
> This verification could be executed for the erasure coding policy before 
> enabling, setting or adding it and a warning message could be written if the 
> verify fails, or the policy setting could be even failed in this case.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to