[
https://issues.apache.org/jira/browse/HDDS-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737706#comment-16737706
]
Bharat Viswanadham edited comment on HDDS-941 at 1/9/19 1:05 AM:
-----------------------------------------------------------------
Hi [~shashikant]
Thanks for the fix.
*Few minor comments:*
1. S3WrapperInputStream.java
Line 34: _Constructs S3WrapperInputStream with BlockInputStream._ _Should_ _be
changed as_ Constructs S3WrapperInputStream with KeyInputStream. #
2. RpcClient.java: can we expand_ org.apache.hadoop.ozone.client.*;, instead of
using *.
3. OzoneInputStrea.java:Should it be Constructs OzoneInputStream with
KeyInputStream, instead of Constructs OzoneInputStream with BlockInputStream?
4. OzoneInputStream.java: Existing one_ It uses SCM's {@link
_BlockInputStream}, do we need SCM's here?
was (Author: bharatviswa):
Hi [~shashikant]
Thanks for the fix.
*Few minor comments:*
1. S3WrapperInputStream.java
Line 34: _Constructs S3WrapperInputStream with BlockInputStream._ _Should_ _be
changed as_ Constructs S3WrapperInputStream with KeyInputStream. #
2. RpcClient.java: can we expand_ org.apache.hadoop.ozone.client.*;, instead of
using *.
3. OzoneInputStrea.java:Should it be Constructs OzoneInputStream with
KeyInputStream, instead of Constructs OzoneInputStream with BlockInputStream?
4. OzoneInputStream.java: Existing one_ It uses SCM's {@link
_BlockInputStream}, do we need SCM's here?
> Rename ChunkGroupInputStream to keyInputStream and ChunkInputStream to
> BlockInputStream
> ---------------------------------------------------------------------------------------
>
> Key: HDDS-941
> URL: https://issues.apache.org/jira/browse/HDDS-941
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Ozone Client
> Affects Versions: 0.4.0
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Major
> Attachments: HDDS-941.000.patch
>
>
> ChunkGroupInputStream reads all blocks for a key and ChunkInputStream reads
> all chunks of a block. It would be convenient to call ChunkGroupInputStream
> to KeyInputStream and ChunkInputStream to BlockInputStream.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
